feat(CC-batch-7): added batch 7 #11869
Conversation
|
Preview: https://patternfly-react-pr-11869.surge.sh A11y report: https://patternfly-react-pr-11869-a11y.surge.sh Preview: https://pf-react-pr-11869.surge.sh A11y report: https://pf-react-pr-11869-a11y.surge.sh |
mattnolting
changed the title
mattnolting
force-pushed
the
feat-CC-batch-7
branch
2 times, most recently
from
1bbee4a to
6ccfde1
Compare
mattnolting
force-pushed
the
feat-CC-batch-7
branch
3 times, most recently
from
fd4bf49 to
f1546dc
Compare
mattnolting
force-pushed
the
feat-CC-batch-7
branch
from
f1546dc to
540457e
Compare
| {props.notificationDrawerHeader} | ||
| <NotificationDrawerBody> | ||
| {props.notificationDrawerGroup} | ||
| <NotificationDrawerList>{props.notificationDrawerNotifications}</NotificationDrawerList> |
There was a problem hiding this comment.
Should this example have both optional groups AND a list? I think you'd want either/or
| onClose={props.hasActionsMenu.onClose} | ||
| title={props.headingText} | ||
| > | ||
| {props.hasActionsMenu.dropdown} |
There was a problem hiding this comment.
Will this still work if the designer doesn't pass a dropdown? Or does figma automatically always have a dropdown? It's not a required prop.
packages/code-connect/components/NotificationDrawer/NotificationDrawerItem.figma.tsx
Outdated
Show resolved
Hide resolved
| // enum | ||
| type: figma.enum('Type', { | ||
| Square: 'square', | ||
| Circle: 'circle' |
There was a problem hiding this comment.
Is there a default shape? in the PF examples, the default skeleton shape is a rectangle if square or circle are not specified.
mattnolting
force-pushed
the
feat-CC-batch-7
branch
from
540457e to
f87a7ce
Compare
| }), | ||
| showUnreadCount: figma.boolean('Has count', { | ||
| true: 3, | ||
| false: NaN |
There was a problem hiding this comment.
count is required to NaN may cause issues, maybe set to 0 instead.
| { | ||
| props: { | ||
| // boolean | ||
| hasCount: figma.boolean('Has count', { |
There was a problem hiding this comment.
Unused, seems to be a dupe of showUnreadCount.
| isOpen={false} | ||
| onOpenChange={() => {}} | ||
| popperProps={{ position: 'right' }} | ||
| toggle={() => ( |
There was a problem hiding this comment.
Pass the toggleRef prop to MenuToggle's ref.
| Success: 'success', | ||
| Warning: 'warning', | ||
| Danger: 'danger' | ||
| }), |
There was a problem hiding this comment.
There is an additional custom value allowed for variant. I don't know if Figma has it explicitly though. It's the default value of variant if nothing is passed in.
| // nested | ||
| pageQuantity: figma.nestedProps('Page quantity selector', { | ||
| itemCount: figma.string('Total quantity'), | ||
| state: figma.enum('State', { Disabled: true }) |
There was a problem hiding this comment.
The state prop looks unused.
| 'Bottom-middle': 'bottom', | ||
| 'Bottom-right': 'bottom-end' | ||
| }), | ||
| status: figma.enum('Status', { |
There was a problem hiding this comment.
icon is unused in the code connect
| component={props.isLink.component} | ||
| href={props.isLink.href} | ||
| isActive={props.isActive} | ||
| key="simple-list-item-key" |
There was a problem hiding this comment.
key is probably unneeded here. It's not a prop of SimpleList, and was probably only in the example because the list items were being created in a array.
| '4XL': '4xl' | ||
| }) | ||
| }, | ||
| example: (props) => <Skeleton fontSize={props.size} type={props.type} screenreaderText="Loading default content" /> |
There was a problem hiding this comment.
There is no type prop, this should be shape instead (which can be circle or square)
mattnolting
force-pushed
the
feat-CC-batch-7
branch
from
f87a7ce to
46a6228
Compare
mattnolting
force-pushed
the
feat-CC-batch-7
branch
from
46a6228 to
3e17d45
Compare
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: